This repository was archived by the owner on Jun 27, 2020. It is now read-only.
#176. Kotlinify AddRecordActivity. #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yev-kanivets
approved these changes
Sep 12, 2019
Owner
yev-kanivets
left a comment
yev-kanivets
left a comment
There was a problem hiding this comment.
Very well 👍 Fix the code style comments and merge it.
| import java.util.* | ||
| import javax.inject.Inject | ||
|
|
||
| /** |
Owner
There was a problem hiding this comment.
Remove this comment, please :)
| private lateinit var uiDecorator: AddRecordUiDecorator | ||
| private lateinit var autoCompleter: CategoryAutoCompleter | ||
|
|
||
| override fun getContentViewId(): Int { |
| super.initData() | ||
| appComponent.inject(this) | ||
|
|
||
| uiDecorator = AddRecordUiDecorator(this) |
Owner
There was a problem hiding this comment.
Can it be moved to initViews? It will allow to have all lateinit properties in one place.
| if (mode == Mode.MODE_EDIT) { | ||
| record?.let { record -> | ||
| etTitle.setText(record.title) | ||
| if (record.category != null) etCategory.setText(record.category?.name.orEmpty()) |
Owner
There was a problem hiding this comment.
Just etCategory.setText(record.category?.name.orEmpty()) may work.
| uiDecorator.decorateActionBar(supportActionBar, mode, type) | ||
| presentSpinnerAccount() | ||
|
|
||
| val categoryAutoCompleteAdapter = CategoryAutoCompleteAdapter( |
Owner
There was a problem hiding this comment.
This block can be extracted as initCategoryAutocomplete.
| tvTime.text = formatController.formatTime(timestamp) | ||
| } | ||
|
|
||
| enum class Mode { |
|
|
||
| @Override | ||
| public View getView(int position, View convertView, ViewGroup parent) { | ||
| public View getView(int position, View convertView, @NotNull ViewGroup parent) { |
| return convertView; | ||
| } | ||
|
|
||
| @Override |
| List<String> tempList; | ||
|
|
||
| if (constraint != null) tempList = autoCompleter.completeByPart(constraint.toString()); | ||
| if (constraint != null) |
| */ | ||
| public class CategoryAutoCompleteAdapter extends ArrayAdapter<String> implements Filterable { | ||
| private final CategoryAutoCompleter autoCompleter; | ||
| private List<String> resultList; |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.